COMP: Fix cmake option for CUDACOMMON_CUDA_VERSION #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake "option" only allows boolean ON|OFF values to
be set as cmake CACHE variables. The
value of CUDACOMMON_CUDA_VERSION is expected to be
a VERSION string like 12.9 or 11.2 which is not
compatible with the cmake "option".
The subsequent
find_package(CUDAToolkit EXACT ${CUDACOMMON_CUDA_VERSION})
Requires the value after EXACT to be a valid version
string (i.e. ON or OFF are invalid choices).
If not set from the command line, default the value
of CUDACOMMON_CUDA_VERSION to the version that was
previously found.
Contributor
Author
|
@SimonRit A fix for cmake build setting of the CUDACOMMON_CUDA_VERSION variable. |
Collaborator
|
Superseded by #86 (just a style adjustment to make pre-commit happy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake "option" only allows boolean ON|OFF values to
be set as cmake CACHE variables. The
value of CUDACOMMON_CUDA_VERSION is expected to be
a VERSION string like 12.9 or 11.2 which is not
compatible with the cmake "option".
The subsequent
find_package(CUDAToolkit EXACT ${CUDACOMMON_CUDA_VERSION})
Requires the value after EXACT to be a valid version
string (i.e. ON or OFF are invalid choices).
If not set from the command line, default the value
of CUDACOMMON_CUDA_VERSION to the version that was
previously found.